June 2017

Thursday 1st

Reviewed PR 99 to webdriver-rust.

Closed issue 760 to geckodriver.

Commented on bug 1369102.

Commented on bug 1369086.

Closed issue 762 to geckodriver.

Closed issue 763 to geckodriver.

Commented on PR 926 to the WebDriver standard.

Reviewed PR 927 to the WebDriver standard which introduces a new ignore state for the user prompt handler to leave user prompt dialogues open.

Reviewed bug 1368492 again.

Provided needinfo on bug 1321432.

Commented on PR 6098 to WPT.

Commented on >bug 1368068. It appears Cu.isDeadWrapper only works on sandboxes after they have been marked with Cu.nukeSandbox. Accessing a property on the nuked sandbox will still cause a TypeError to be thrown.

Reviewed PR 929 to the WebDriver standard.

Reviewed PR 6098 to WPT again.

Patched bug 1368264 to hook the in-tree built geckodriver up to WPT.

Friday 2nd

Merged PR 6098 to WPT.

Reviewed PR 6137 to WPT.

Reviewed bug 1369708.

Reviewed bug 1364385.

Reviewed bug 1369700.

Reviewed bug 1369413.

Saturday 3rd

Commented on bug 1363368.

Commented on bug 1369708.

Commented on bug 1369596.

Reviewed PR 935 to the WebDriver standard.

Monday 5th

Commented on issue 767 to geckodriver.

Closed issue 766 to geckodriver as fullscreen support in Marionette was added in bug 1189749.

Closed issue 765 to geckodriver as there is not enough information to reproduce.

Continued work on bug 1368264 to hook the in-tree geckodriver up to WPT.

Filed and patched bug 1370191 to update the bug component for WPT wdspec tests.

Commented on issue 695 to geckodriver.

Submitted PR 936 to the WebDriver standard.

Reviewed PR 937 to the WebDriver standard.

Reviewed PR 938 to the WebDriver standard.

Tuesday 6th

Reviewed bug 1367430.

Provided needinfo on bug 1223277.

Reviewed bug 1368674.

Provided needinfo on bug 1369923.

Commented on PR 940 to the WebDriver specification.

Provided needinfo on bug 1369827.

Reviewed PR 768 to the tombstoned geckodriver repository, to improve the issue template used on GitHub.

Requested needinfo on bug 1369596.

Commented on bug 1364762.

Commented on bug 1370223.

Provided needinfo on bug 1370535.

Reviewed PR 942 to the WebDriver specification.

Reviewed PR 941 to the WebDriver specification.

Commented on on geckodriver with regards to adding a /shutdown endpoint.

Provided needinfo on bug 1369709.

Provided needinfo on bug 1370597.

Filed bug 1370636.

Reviewed PR 944 to the WebDriver specification.

Reviewed PR 943 to the WebDriver specification.

Fixed code review issues with bug 1368264.

Rebased and landed bug 1370597.

Wednesday 7th

Commented on PR 940 regarding the W3C CR patch process.

Commented on bug 1364762.

Closed issue 774 to geckodriver.

Closed issue 773 to geckodriver.

Commented on issue 706 to geckodriver.

Closed issue 772 to geckodriver as I believe it got fixed by bug 1367430.

Commented on issue 771 to geckodriver.

Patched bug 1370850 to ensure the Execute Script and Execute Async Script commands return a value field on the JSON Object when a user prompt, caused by i.e. window.alert, causes the proxied content frame script call to be interrupted.

Filed and patched bug 1370857.

Reviewed bug 1370510.

Filed and worked on bug 1370863 to discontinue server logging in Marionette.

Filed and patched bug 1370871 to remove the global global variable from the evaluate script sandboxes in Marionette.

Attended Marionette meeting.

Attended Product Integrity meeting.

Thursday 8th

Fixed test failures with bug 1368195.

Fixed test failures with bug 1370871.

Rebased bug 1370857.

Cancelled review request for bug 1370899 because I don’t feel comfortable reviewing this code.

Reviewed bug 1369709.

Closed issue 777 to geckodriver as selecting a checkbox is not supposed to be possible using the high-level Element Send Keys command.

Addressed code review issues with bug 1370850.

Spent the majority of the day investigating a startup crash, reported in bug 1371319. Curiously, it only manifests itself on tristan, and not my main workstation.

Closed bug 1369102 as a duplicate of bug 1370863. I appear to have filed the same bug twice.

Reviewed PR 6188 to WPT.

Rebased and fixed some minor nits with bug 1370863 to remove the commands to store logs in the Marionette server.

Rebased bug 1370857 which removes the import script APIs from the Marionette Python client.

Addressed some of the review comments made on bug 1368195. I do however disagree with some of them.

Commented on issue 777 to geckodriver.

Commented on issue 776 to geckodriver.

Commented on issue 773 to geckodriver.

Commented on issue 775 to geckodriver.

Reviewed bug 1371358.

Friday 9th

Commented on PR 127 to the Selenium docs.

Closed issue 778 to geckodriver.

Closed issue 779 to geckodriver.

Provided needinfo on bug 1368262. Not entirely sure what I was supposed to say.

Reviewed bug 1369709 again.

Reviewed bug 1371405.

Provided needinfo on bug 1368492.

Commented on bug 1332122.

Spent some looking into bug 1368262 together with jgraham and hskupin, and we found that when the RELEASE_OR_BETA ifdef is set, which can be caused by removing the “a” (alpha) character from config/milestone.txt, this causes sandboxed processes to get disabled, causing testing/web-platform/tests/webdriver/navigation.py’s file: URL test to start passing because it is no longer reloading the content frame script. With sandboxed processes enabled, content frame scripts are reloaded as Marionette navigates to a file: URL, but Marionette currently assumes that a frame script reload is always linked to when a remoteness change occurs. There is bug 1332122 to fix this assumption.

Commented on issue 949 regarding the proxy configuration object input on the WebDriver standard.

Commented on PR 948 to the WebDriver specification.

Closed issue 431 to geckodriver.

Commented on< a href=https://github.com/mozilla/geckodriver/issues/743>issue 743 to geckodriver and updated the README accordingly.

Rebased and fixed up bug 1370863.

Fixed code review issues with bug 1370871.

Fixed code review issues with bug 1368195.

Filed and patched bug 1371658.

Triaged and commmented on issue 780 regarding user prompt dialogues being counted as window handles.

Commented on issue 771 to geckodriver regarding termianting the process versus implementing a /shutdown endpoint.

Reviewed bug 1368492.

Filed and patched bug 1371707 which fixes the Travis apt packages for Linux x86 builds of geckodriver.

Released geckodriver 0.17.0.

Reviewed PR 7 to rust-mozprofile.

Filed and patched bug 1371718 to recommend Firefox 53 or greater when using geckodriver.

Reviewed PR 8 to rust-mozprofile.

Provided needinfo on bug 1369709.

Started reviewing bug 1371709.

Filed and patched bug 1371730.

Filed bug 1371733 about moving the cookie service to chrome.

Saturday 10 June

Reviewed bug 1368262.

Worked on bug 1371733.

Monday 12th

Provided needinfo on bug 1371576.

Provided needinfo and patched bug 1364319 to make Marionette’s setWindowRect command more reliable.

Reviewed bug 1371405.

Reviewed bug 1371709.

Reviewed bug 1363428.

Provided needinfo on bug 1368492.

Provided needinfo on bug 1371707.

Rebased and addressed code review issues with bug 1370863.

Addressed code review issue with bug 1368195.

Addressed code review issues with bug 1371718.

Reviewed PR 9 to rust-mozrunner.

Pushed an early version of the cookie service rewrite patch to bug 1371733.

Tuesday 13th

Triaged issue 951 to the WebDriver specification about making the scroll into view functionality configurable.

Commented on bug 1371707 regarding my patch to fix the Travis build environment for geckodriver.

Commented on bug 1371733.

Provided needinfo on bug 1370863.

Closed bug 1371905 as a duplicate of bug 1371924.

Work on bug 1371733 to move the cookie service to chrome context.

Filed bug 1372582 about making the cookie service in Marionette WebDriver conforming, as a follow up to bug 1371733.

Filed bug 1372587 to track releasing geckodriver from TaskCluster.

Commented on bug 1358978 regarding having a “repeat until first failure” option for the Marionette test harness.

Commented on issue 782 to geckodriver regarding a cookie related issue.

Reviewed PR 9 to rust-mozrunner to parse the profile flag to Firefox.

Wednesday 14th

Commented on issue 672 to geckodriver.

Provided needinfo on bug 1282970 regarding feature parity between Marionette and geckodriver.

Closed issue 782 as it was resolved recently by bug 1362990.

Reviewed bug 1368965.

Reviewed bug 1371405.

Reviewed PR 9 to rust-mozrunner.

Attended Marionette meeting.

Had 1:1 with dburns.

Reviewed bug 1368072.

Commented on bug 1272255<>/a>.

Commented on issue 783 to geckodriver.

Commented on issue 647 to geckodriver.

Rebased bug 1364319.

Thursday 15th

Closed issue 784 to geckodriver as it does not make any sense.

Commented on bug 1364319.

Reopened issue 782 and filed (and fixed) bug 1373218.

Reviewed bug 1371709.

Reviewed bug 1373216.

Commented on bug 1369670.

Reviewed PR 101 to webdriver-rust.

Reviewed PR 10 to rust-mozrunner.

Closed issue 785 to geckodriver. I don’t think it is the responsibility of the geckodriver developers to provide packaging of the program.

Friday 16th

Commented on issue 786 to geckodriver.

Requested uplift of bug to beta (55).

Fixed a test failure with bug 1364319. It appears we need to request an additional animation frame after moving the window out of fullscreen mode so it gets time to resize to its original size, before we try to resize it again. I was able to find this very quickly thanks to the new --run-until-failure flag that whimboo added to the Marionette harness.

Reviewed bug 1370936.

Rebased bug 1371733.

Rebased and triggered new try runs for bug 1370863 because I wasn’t able to reproduce the test failure that the patches got backed out for in the first place.

Commented on issue 786 to geckodriver.

Closed issue 787 to geckodriver as a duplicate of issue 285.

Provided needinfo on bug 1373502.

Commented on issue 463 about returning the cookie expiry date, as I’m very likely to fix it as part of working on bug 1372595.

Submitted PR 102 to webdriver-rust as a dependency to bug 1372595.

Patched bug 1372595.

Reviewed bug 1373709.

Reviewed bug 1373635.

Closed issue 788 to geckodriver.

Reviewed PR 104 to webdriver-rust.

Commented on bug 1374263.

Monday 19th

Commented on bug 1373879.

Reviewed bug 1371405.

Rebased bug 1372595.

Commented on bug 1371405.

Commented on bug 1374323.

Provided needinfo on bug 1370863.

Commented on issue 789 to geckodriver.

Commented on issue 788 to geckodriver.

Commented on bug 1372595.

Filed bug 1374391.

Tuesday 20th

Reviewed last remaining bits of bug 1363428 to land the reftest-in-Marionette harness.

Addressed review comments for bug 1371733.

Commented on bug 1305248.

Commented on issue 790 to geckodriver about navigating to the same document with a hash.

Commented on issue 789 to geckodriver. Still a useless bug report.

Closed bug 1374323 as a duplicate of bug 1370863.

Addressed code review issues with bug 1370863.

Spent some time triaging and commenting on issue 790 to geckodriver and navigation to the same hash no longer working.

Spent quite a long time trying to figure out bug 1364319 and managed to reduce the intermittency rate, but there is something fundamentally wrong with window.outerWidth and window.outerHeight.

Wednesday 21st

Fixed code review issues with bug 1371733.

Attended tea tasting session organised by jgraham in the office! 🍵

Submitted a revised patch for bug 1364319 which appears to have made the intermittent problems go away, at least locally on my workstation. However, the patch is terrible, in the sense that it uses brute force to overcome inherent problems with populating DOM properties.

Reviewed PR 959 to the WebDriver specification.

Closed and commented on issue 958 to the WebDriver specification regarding some confusion about WindowProxy serialisation.

Submitted PR 960 to the WebDriver specification.

Requested needinfo on bug 1360446 because we need to run test_click.py on e10s.

Addressed code review comments for bug 1370863 to remove the server log API from Marionette.

Closed issue 791 as it was fixed by bug 1357878.

Closed bug 1373879 as a duplicate of bug 1364319.

Closed issue 955 to the WebDriver specification.

Commented on bug 1374977.

Filed bug 1375207 to include the SHA1 off which geckodriver was built in the output from --version.

Thursday 22nd

Reviewed bug 1354750.

Reviewed bug 1368072.

Provided needinfo and resolved bug 1375342 as a duplicate of bug 1368072. I knew farre was making a change to the API I was using, but it I didn’t anticipate that we would push our changes approximately at the same time.

Provided needinfo on bug 1375104.

Commented on bug 1370863.

Filed and patched bug 1375425 to namespace Marionette commands in such a way that we in the future can enable- and disable individual services.

Patched bug 1375207 to include the curren tip's SHA1 in geckodriver’s version information as we are no longer able to tag releases because it lives in mozilla-central.

Addressed code review issues with bug 1371733.

Commented on bug 1375451.

Commented on issue 792 to geckodriver regarding serialisation of recursive objects.

Commented on bug 1333333 regarding the fallout from bug 1368072.

Rebased bug 1372595.

Attended town hall meeting.

Friday 23rd

Reviewed bug 1363428.

Reviewed bug 1223277.

Provided needinfo on bug 1375451.

Edited the geckodriver README on GitHub following a suggestion in issue 794.

Commented on bug 1375104.

Patched bug 1374977. to include the geckodriver version in the log.

Reviewed bug 1375259.

Commented on issue 795 to geckodriver.

Saturday 24th

Filed and worked on bug 1376128 to enable linting of testing/marionette.

Sunday 25th

Arrived in San Francisco for the Mozilla All Hands.

Commented on issue 792 to geckodriver regrading script evaluation recursion.

Tuesday 27th

Attended All Hands.

Reviewed bug 1370223 which adds WPT tests for the Maximize Window command.

Filed and patched bug 1376586 where I reintroduce the quitApplication command that geckodriver still relies on, after having accidentally removed it in bug 1375425.

Work on bug 1376128.

Wednesday 28th

Attended All Hands.

Reviewed bug 1364389, which introduces Set Window Rect and Get Window Rect command tests for WPT and WebDriver.

Reviewed bug 1375104.

Provided needinfo on bug 1376689.

Submitted patches for bug 1376128 to lint testing/marionette.

Rebased bug 1372595.

Closed issue 803 to geckodriver for not being reproducible.

Closed issue 802 to geckodriver because text-transform is known not to work with the Get text command’s JS atom from Selenium.

Thursday 29th

Attended All Hands.

Commented on issue 3943 on Selenium regarding log output from geckodriver.

Did a session about Marionette and the test automation ecosystem at Mozilla, together with maja_zf, whimboo, and jgraham. It went very well, I think.

Commented on issue 726 to geckodriver.

Commented on issue 473 to geckodriver.

Rebased bug 1376128.

Rebased bug 1372595.

Commented on isse 595 to the WebDriver specification regarding sharing key modifier state across actions in a chain.

Commented on issue 804 to geckodriver.

Closed issue 797 to geckodriver since no reproducible information was added.

Closed issue 798 to geckodriver as it is not reproducible.

Commented on issue 3693 to Selenium regarding sendKeysToActiveElement and mouseMoveTo WebDriver action API primitives, which need a shim implementation.

Commented on issue 802 to geckodriver regarding text-transform in the Selenium JS atom that Marionette uses.

Reopened and commented on issue 634 to geckodriver, which turns out to be bug 1363418, which is about supporting the http-equiv=refresh rule.

Commented on issue 933 to the WebDriver standard regarding removing some prose about innerText.

Closed issue 796 and answered some questions about cross-compiling geckodriver for ARMv6 devices.

Work on window tracking.

Friday 30rd

Reviewed bug 1368068.

Commented on issue 152 to geckodriver.

Reviewed PR 969 to the WebDriver specification regarding setting cookie expiry date.

Reviewed bug 1374762.

Work on the new window tracking code.

Commented on issue 3943 to Selenium regarding geckodriver logging.