October 2017

Monday 2nd

Addressed test failures with bug 1403577.

Reviewed WPT PR 7537.

Reviewed WPT PR 7515.

Commented on bug 1397069.

Closed geckodriver issue 986 as a duplicate of issue 951.

Commented on and closed geckodriver issue 725.

Closed geckodriver issue 982.

Commented on geckodriver issue 985.

Closed geckodriver issue 984.

Commented on WPT PR 7461.

Commented on geckodriver issue 983.

Commented on WPT PR 7301.

Commented on bug 1403510.

Reviewed WPT PR 6996.

Reviewed WPT PR 7441.

Commented on bug 1403689.

Merged WPT PR 7409.

Reviewed bug 1402978 which adds support for the domain field to the WebDriver:AddCookie command.

Commented on geckodriver issue 977 and filed WebDriver issue 1121 as a follow up.

Submitted PR 1122 to the WebDriver specification, fixing issue 1102.

Filed and patched bug 1404946 which renames testing/marionette/wait.js to testing/marionette/sync.js.

Filed and patched bug 1405004.

Closed geckodriver issue 987.

Commented on bug 1321516.

Triaged geckodriver issue 934 and filed bug 1405018. It looks like my recent changes to element.isStale does not take into account what the chosen current browsing context is. This will cause problems for elements which associated document still exists, for example an element retrieved from an <iframe>.

Patched bug 1405018.

Addressed code review issues with bug 1403577.

Replied to a very thoughtful clarification from Jason Juang on bug 1321516.

Addressed some test failures with bug 1405018.

Submitted deliverables.

Provided needinfo on bug 1365308.

Tuesday 3rd

Commented on geckodriver issue 988.

Closed geckodriver issue 950.

Closed geckodriver issue 963.

Reviewed bug 1404891.

Reviewed bug 1375660.

Reviewed bug 1402978.

Commented on bug 1405004.

Triaged and commented on geckodriver issue 980.

Commented on geckodriver issue 979.

Commented on WPT PR 6996.

Reviewed WPT PR 7441.

Filed and patched bug 1405279 to lint Marionette for unused variables and commented on bug 1405004.

Filed and patched bug 1405304 that provides a new report formatter for mozlint using Unix conventions.

Commented on WPT issue 7556.

Assigned bug 1405240.

Filed and patched bug 1405325 as a follow-up to geckodriver issue 989.

Addressed code review comments with bug 1405304.

Closed geckodriver issue 993.

Closed geckodriver issue 992.

Closed geckodriver issue 991.

Commented on geckodriver issue 990.

Reviewed bug 1405240.

Requested needinfo on bug 1405240.

Closed geckodriver issue 995.

Commented on geckodriver issue 994.

Addressed test failures for bug 1405304.

Wednesday 4th

Filed bug 1405668, requesting commit access level 1 for Peter Major, who has recently submitted some high-quality fixes for Marionette.

Commented on bug 1405240, and tried to re-land it.

1:1 with dburns.

Attended Marionette meeting.

Provided needinfo on bug 1375660 and filed bug 1405757 as a follow-up.

Patched bug 1405757.

Reviewed bug 1375660.

Provided needinfo and requested uplift of bug 1402978.

Addressed code review issues with bug 1405018.

Addressed code review issues with bug 1405279.

Addressed code review issues with bug 1404946.

Commented on geckodriver issue 988.

Commented on geckodriver issue 998.

Closed geckodriver issue 994.

Closed geckodriver issue 997.

Commented on bug 1375660.

Addressed more code review issues with bug 1405018.

Thursday 5th

Commented on bug 1403923.

Commented on geckodriver issue 980.

Reviewed bug 1375660.

Filed bug 1406006.

Addressed code review issues with bug 1405018.

Reassigned reviews and rebased bug 1405325.

Closed geckodriver issue 999.

Commented on WebDriver issue 385.

Finally submitted patches for bug 1400256, introducing web element abstractions to Marionette.

Addressed more code review comments with bug 1405325.

Addressed even more code review comments with bug 1403577.

Addressed code review comments with Bug 1404946.

Re-requested review on bug 1405018.

Monday 9th

Provided needinfo on bug 1275273.

Provided needinfo on bug 1406132.

Provided needinfo on bug 1403923.

Provided needinfo on bug 1399633.

Rebased bug 1405325.

Re-requested review on bug 1403577.

Commented on geckodriver issue 1004.

Filed and patched bug 1406965 which adds a howto on how to enable trace-level logs with geckodriver.

Provided needinfo on, rebased, and fixed linting mistakes with bug 1404946.

Rebased bug 1405325 again due to conflicts autolanding it because of conflicts in WPT’s MANIFEST.json.

Closed geckodriver issue 1008.

Closed geckodriver issue 1006.

Commented on geckodriver issue 991.

Filed and patched bug 1407000.

Closed geckodriver issue 1003.

Commented on WPT PR 7301.

Addressed code review issues and test failures for bug 1400256.

Commented on geckodriver issue 570.

Tuesday 10th

Commented on WebDriver PR 1123 regarding determinism for the Get Window Handles command.

Rebased bug 1405325.

Commented on geckodriver issue 570.

Commented on geckodriver issue 1004.

Closed WebDriver issue 1124.

Commented on geckodriver issue 1001.

Commented on geckodriver issue 1000.

Commented on geckodriver issue 1009.

Addressed code review issues with bug 1400256.

Commented on bug 1403923.

Filed and patched bug 1407224.

Submitted new patches for bug 1275273 to wean Marionette off Selenium atoms.

Rebased bug 1405018.

Reviewed WebDriver PR 1120.

Addressed a linting mistake with bug 1275273.

Added a few agenda items for the WebDriver F2F meeting in Burlingame, CA in November.

Wednesday 11th

Provided needinfo on bug 1405325.

Commented on geckodriver issue 1010.

Attended Marionette meeting.

Filed and patched bug 1407714 to improve the geckodriver contribution guide.

Filed and patched bug 1407716 to convert Marionette’s README to Markdown.

Thursday 12th

Commented on geckodriver issue 299.

Triaged bug 1399362.

Commented on geckodriver issue 1011.

Commented on geckodriver issue 1000.

Requested uplift of bug 1405325.

Commented on bug 1407675.

Triaged bug 1407925.

Commented on bug 1407695.

Commented on geckodriver issue 1013.

Filed and patched bug 1407963.

Filed and patched bug 1407969.

Reviewed bug 1406763.

Requested uplift of bug 1405018.

Closed geckodriver issue 1013.

Closed geckodriver issue 1012.

Addressed code review issues with bug 1403577.

Reviewed bug 1407925.

Friday 13th

Commented on geckodriver issue 1013.

Commented on bug 1407675.

Filed and patched bug 1408431.

Addressed some issues with bug 1407985.

Patched bug 1407990.

Filed and patched bug 1408454.

Filed bug 1408508.

Rebased and addressed code review issues for bug 1400256.

Reviewed WPT PR 7769.

Sunday 15th

Closed geckodriver issue 1016.

Monday 16th

Addressed test failures with bug 1400256.

Filed and patched bug 1409026, bug 1409031, bug 1409037, and bug 1409040 to split out a number of patches from bug 1400256.

Closed bug 1409026.

Reviewed bug 1409030.

Submitted WPT PR 7845 to remove the old WebDriver tests, and commented on WPT issue 7556.

Patched bug 1408508.

Commented on geckodriver issue 1017.

Commented on geckodriver issue 1015.

Commented on WebDriver issue 1129.

Commented on bug 1354211.

Commented on geckodriver issue 243.

Reviewed WebDriver PR 1127.

Tuesday 17th

Commented on geckodriver issue 1018.

Reviewed WebDriver PR 1130.

Rebased bug 1408508.

Addressed code review issues with bug 1408508.

Commented on geckodriver issue 1017.

Filed and patched bug 1409379.

Fixed test failures with bug 1409040.

Triaged bug 1409195.

Did a one-off local cross compile of geckodriver for Windows x86, resolving geckodriver issue 951.

Filed and patched bug 1409438.

Commented on geckodriver issue 1019.

Wednesday 18th

Reviewed bug 1396880.

1:1 with dburns.

Marionette meeting.

Rebased bug 1408508.

Reviewed WebDriver PR 1131.

Closed geckodriver issue 980.

Rebased bug 1409040.

Commented on geckodriver issue 1020.

Reviewed bug 1405474.

Thursday 19th

Reviewed, massaged and rebased bug 1409195.

Commented on bug 1409981.

Reviewed bug 1405474.

Provided needinfo on bug 1408962.

Filed and patched bug 1410069.

Rebased and addressed code review issues with bug 1400256.

Addressed code review issues with bug 1410069.

Wrote about reviews on in-tree documentation to the dev-platform mailing list.

Commented on geckodriver issue 1019.

Fixed some test failures caused by the latest rebase for bug 1400256.

Closed geckodriver issue 1021.

Friday 20th

Commented on WPT PR 7909.

Reviewed bug 1407695.

Reviewed bug 1408962.

Commented on geckodriver issue 1011.

Closed geckodriver issue 1014.

Commented on geckodriver issue 1023.

Saturday 21st

Filed and patched bug 1410649.

Filed and patched bug 1410652.

Monday 23rd

Filed and patched bug 1410891.

Requested needinfo on bug 1410366.

Requested needinfo on bug 1410355.

Reviewed bug 1407695.

Reviewed bug 1403428.

Reviewed bug 1410355.

Reviewed and provided needinfo on bug 1406505.

Reviewed bug 1410366.

Commented on WebDriver issue 1086.

Filed and patched bug 1411026 to fix propagation of Marionette stacktraces through geckodriver.

Filed and patched bug 1411045 to display the remote end’s stacktrace when assert_success in the WPT tests fails.

Filed and patched bug 1411052.

Reviewed bug 1407695.

Tueday 24th

Reviewed bug 1407695.

Provided needinfo on bug 1407383.

Locked geckodriver issue 270.

Commented on geckodriver issue 1027.

Closed geckodriver issue 1024.

Filed and patched bug 1411307.

Rebased, addressed test failures and code review issues with bug 1410652.

Filed bug 1411281.

Filed bug 1411286, and did a significant amount of work in that area.

Wednesday 25th

Reviewed bug 1411433.

Rebased and addressed code review issues with bug 1411045.

Closed geckodriver issue 1028.

Commented on geckodriver issue 1030.

Closed geckodriver issue 1027.

Commented on bug 1411393.

Rebased and addressed code review issues with bug 1410891.

Provided needinfo on bug 1094246.

Commented on geckodriver issue 1029.

Commented on bug 1411366.

Filed bug 1411513 about Log.jsm not being e10s compatible. Commented on bug 1384956.

Addressed test failures and code review issues with bug 1410652.

Patched bug 1411281.

Closed geckodriver issue 1031.

Reviewed bug 1401498.

Commented on WPT PR 6996.

Provided some review on Execute Script/Execute Async Script tests that a Microsoft employee has written.

Commented on bug 1411207.

Reviewed bug 1411611.

Reviewed bug 1405474 and filed bug 1411634 as a follow-up.

Thursday 26th

Addressed code review issues with bug 1411281.

Filed bug 1412037 to release geckodriver 0.19.1.

Reviewed bug 1412222.

Filed wptdashboard issue 182.

Published a new sysexit Rust library.

Addressed code review comments with bug 1411281.

Monday 30th

Closed geckodriver issue 1035.

Closed geckodriver issue 1034.

Commented on WebDriver issue 1137.

Closed geckodriver issue 1033.

Commented on geckodriver issue 1030.

Rebased and addressed code review issues with bug 1411281.

Reviewed PR 7945.

Patched bug 1412037.

Provided needinfo on bug 1412236.

Commented on geckodriver issue 786.

Rebased and addressed code review issues with bug 1411307.

Commented on bug 1410649.

Rebased bug 1410652.

Tuesday 31st

Half day PTO.

Reviewed bug 1412904.

Provided needinfo on bug 1413195.

Commented on geckodriver issue 345.

Closed WebDriver issue 1136.

Provided needinfo on bug 1412904.

Commented on bug 1407383.

Released geckodriver 0.19.1.

Patched bug 1410796.

Provided needinfo on bug 1410652, rebased it, and fixed a lint failure.

Commented on bug 1412904.

Patched bug 1413292 to drop backtrace substitutes for missing Marionette stacks from geckodriver.

Commented on bug 1413292 and filed bug 1413326 as a follow-up for also removing stacktraces for WebDriver errors in Marionette.