January 2018

Tuesday 2nd

Patched bug 1379490.

Addressed test failures with bug 1354211.

Rebased and addressed code review issues with bug 1425708.

Commented on WebDriver issue 385.

Commented on geckodriver issue 1119.

Closed geckodriver issue 1118.

Closed geckodriver issue 1117.

Re-opened and commented on geckodriver issue 1116.

Closed geckodriver issue 1113.

Closed geckodriver issue 1114.

Commented on and locked geckodriver issue 744.

Provided needinfo on bug 1407383.

Filed bug 1427596.

Rebased and addressed code review issues with bug 1425317.

Lots of work on marionette-window-tracking.

Wednesday 3rd

PTO.

Commented on and closed geckodriver issue 1120.

Closed geckodriver issue 1119.

Commented on geckodriver issue 1096 regarding zero-height document elements. <body> and <html> are considered special elements by the CSS Backgrounds standard because their background styling gets ‘transposed’ on to the document canvas.

Commented on and locked geckodriver issue 1099.

Provided needinfo on bug 1427807.

Thursday 4th

Responded to code review comments on bug 1354211.

Lots of work on marionette-window-tracking.

Friday 5th

Commented on geckodriver issue 1121.

Commented on geckodriver issue 665.

Commented on bug 1294933. Looks like opening the About dialogue and closing it removes the ‘New Window’ option from the dock menu on macOS.

Filed WebDriver issue 1181 about WebIDL parsing problems.

Lots of more work on marionette-window-tracking.

Commented on WebDriver PR 1177.

Saturday 6th

Reviewed WebDriver PR 1177.

Sunday 7th

Continued work on marionette-window-tracking.

Monday 8th

Provided needinfo on bug 1385706.

Reviewed WebDriver PR 1182.

Addressed code review issues and rebased bug 1354211.

Reviewed WebDriver PR 1184.

Reviewed WebDriver PR 1185.

Commented on bug 1428795.

Continued work on marionette-window-tracking.

Commented on bug 1427990.

Filed bug 1428813 and bug 1428814.

Reviewed bug 1385706.

Reviewed WebDriver PR 1186.

Commented on geckodriver issue 729.

Tuesday 9th

Reviewed bug 1385706.

Closed geckodriver issue 322.

Closed geckodriver issue 1073.

Closed geckodriver issue 1087.

Reopened and commented on geckodriver issue 1007.

Continued work on marionette-window-tracking.

Filed and patched bug 1429083 to lazy load uuid-generator in the Marionette proxy module.

Filed and patched bug 1429082 to remove AsyncChromeSender and SyncChromeSender from the Marionette proxy module.

Filed and patched bug 1429091 to have the proxy module always use the global message manager so that a message manager does not have to be passed in.

Responded to code review issue with bug 1354211.

Filed WebDriver issue 1187 after having commented on geckodriver issue 1107.

Filed and patched bug 1429111 to remove an unused instance of nsITimer from element.Store.

Commented on bug 1420472.

Filed and patched bug 1429116.

Commented on bug 1347458 regarding a possible idea for solving the problem of losing IPC messages when a remoteness change occurs.

Commented on geckodriver issue 1123.

Commented on geckodriver issue 939.

Had a good conversation with paolo about good IPC practices in Firefox code.

Locked geckodriver issue 420.

Wednesday 10th

Reviewed WebDriver PR 1188.

Submitted WebDriver PR 1189 to prevent <option disabled>’s selectedness state from being toggled when because it is disabled.

Filed bug 1429388 and requested needinfo on it.

Provided needinfo on bug 1421766.

Filed WebDriver issue 1190 about descendants of <optgroup disabled> also being disabled.

Filed and patched bug 1429384 which provides the necessary specification tests for WebDriver PR 1189.

Filed bug 1429403.

Rebased bug 1426154.

Commented on geckodriver issue 1123.

Commented on WebDriver issue 1171.

Commented on bug 1429388.

Reviewed WPT PR 8975.

Patched bug 1429388.

Had 1:1 with dburns.

Attended Marionette meeting.

Addressed test failures with bug 1426154.

Reviewed mozrunner PR 17.

Filed bug 1429511 and requested needinfo.

Reviewed WPT PR 8979, which adds support for the Safari WebDriver implementation to WPT.

Commented on bug 1413292.

Thursday 11th

Reviewed bug 1429562:

Commented on bug 1429867.

Commented on bug 1287450.

Rebased bug 1429091.

Friday 12th

Closed geckodriver issue 1126.

Commented on geckodriver issue 1020.

Commented on bug 1429338.

Commented on geckodriver issue 1128.

Commented on geckodriver issue 284.

Reviewed bug 1430025.

Commented on and locked geckodriver issue 737.

Commented on bug 1419226.

Continued work on marionette-window-tracking.

Filed and patched bug 1430077.

Reviewed bug 1385706.

Commented on WebDriver PR 1189.

Filed and patched bug 1430109.

Filed and patched bug 1430119.

Patched bug 1429511, bug 1430152, and bug 1430157. Also filed bug 1430158.

Closed geckodriver issue 1020.

Sunday 14th

Commented on geckodriver issue 823.

Rebased and addressed code review issues with bug 1430109.

Monday 15th

Commented on bug 1354203.

Provided needinfo, rebased, and fixed test failures with bug 1430109.

Rebased and addressed code review issue with bug 1430077.

Reviewed bug 1385706.

Provided needinfo on bug 1430575. It turns out that checking the value property of a validation field such as <input type=number> is not sufficient to check whether it needs to be cleared. Gecko allows you to type invalid characters into the field, but the value property is not updated unless the inputted characters are valid. Filed WebDriver issue 1193 to fix the problem in the specification.

Requested needinfos on bug 1287450.

Patched bug 1430575.

Filed issue 1194 and issue 1195 against the WebDriver standard.

Submitted WebDriver PR 1196 to fix issue 1193.

Provided needinfo on bug 1430571.

Tuesday 16th

Commented on geckodriver issue 1127.

Commented on geckodriver issue 737:

Wednesday 17th

Replied to email about VPN requirements for London.

Rebased and addressed code review issues with bug 1430575.

Rebased and addressed code review issue with bug 1430152 and bug 1429511.

Patched bug 1413326.

Filed and patched bug 1431089.

Requested needinfo on bug 1431048.

Closed geckodriver issue 1131 and commented on geckodriver issue 906.

Updated description of bug 1294933.

Commented on bug 1429511.

Commented on geckodriver issue 979.

Commented on geckodriver issue 1124.

Commented on geckodriver issue 1129.

Commented on bug 1385706.

Filed bug 1431116.

Closed bug 1398087 as a duplicate of bug 1385706.

Commented on geckodriver issue 1129.

Filed bug 1431148 and commented on geckodriver issue 570.

Attended Marionette meeting.

Rebased and continued work on marionette-window-tracking.

Provided needinfo on bug 1431151.

Patched bug 1431151.

Filed and patched bug 1431155.

Commented on Selenium PR 116.

Requested needinfo on bug 1431151.

Thursday 18th

Reviewed bug 1430123.

Provided needinfo on bug 1430851.

Responded to review comment in bug 1431155.

Requested needinfo on bug 1431151.

Requested needinfo on bug 1413326.

Closed geckodriver issue 1136.

Commented on WebDriver issue 1199.

Bug 1431155 got backed out for not being called. I fixed the temporary problem by removing wm.js from the JAR manifest.

Closed geckodriver issue 1122.

Filed bug 1431459.

Filed and patched bug 1431462.

Continued work on marionette-window-tracking.

Friday 19th

Commented on geckodriver issue 1124.

Closed WebDriver issue 1200.

Commented on geckodriver issue 979.

Provided needinfo on bug 1429338.

Requested needinfo on bug 1431459.

Commented on bug 1407383.

Provided another needinfo on bug 1429338.

Worked a bit on bug 1169290 and discovered some problems with how the Marionette XPCOM component gets initialised.

Monday 22nd

Closed WebDriver issue 1201.

Rebased marionette-window-tracking.

Provided needinfo on bug 1374283.

Commented on bug 1431151.

Requested needinfo on bug 1431151. Also rebased it.

Filed and patched bug 1432212.

Commented on geckodriver issue 1140.

Tuesday 23rd

Commented on geckodriver issue 1139.

Continued work on marionette-window-tracking.

Closed bug 1431151.

Filed bug 1432538.

Commented on geckodriver issue 939.

Requested needinfo on bug 1429338.

Wednesday 24th

Commented on WebDriver issue 1206.

Commented on WebDriver issue 1205.

Reviewed bug 1399158.

Filed bug 1432792 to follow up after bug 1432212. Also rebased and commented on bug 1432212.

Commented on geckodriver issue 1141.

Closed geckodriver PR 1142.

Patched bug 1432538.

Filed and patched bug 1432804.

Reviewed bug 1432475.

Patched bug 1430571.

Filed and patched bug 1432864.

Patched bug 1432813.

Filed bug 1432894.

Closed geckodriver issues 1139 and 983.

Made some fixups to the geckodriver README.

Regenerated Marionette API documentation.

Attended Marionette meeting.

Submitted WebDriver PR 1207.

Filed WebDriver issue 1208.

Thursday 25th

Commented on WebDriver issue 1209.

Rebased and addressed code review issue with bug 1432864.

Rebased bug 1432864.

Reviewed WPT PR 9198.

Commented on WebDriver PR 1210.

Closed geckodriver issue 1143.

Friday 26th

Reviewed WPT PR 9206.

Provided needinfo on and patched bug 1433422.

Provided needinfo on bug 1433463 and filed WebDriver issue 1212 to follow up on the specification concern.

Provided needinfo on bug 1433297. Also submitted a patch for the same bug.

Filed and patched bug 1433497.

Filed and patched bug 1433501.

Responded to code review issues on bug 1433297.

Worked on bug 1169290 but I’ve basically concluded it is the right thing to do to bring back the marionette.enabled preference.

Rebased marionette-window-tracking.

Saturday 27th

Worked on bug 1169290.

Monday 29th

Commented on geckodriver issue 1146.

Closed geckodriver issue 1147.

Commented on bug 1433497.

Commented on geckodriver issue 1148.

Attended Marionette meeting.

Commented on WebDriver issue 1214.

Commented on and submitted patches for bug 1169290.

Rebased and continued work on marionette-window-tracking.

Attended internal meeting.

Tuesday 30th

Reviewed bug 1434123 and filed bug 1434219 as a follow-up to get rid of the marionette.defaultPrefs.port pref.

Requested uplift of bug 1433422.

Commented on geckodriver issue 1148.

Closed geckodriver issue 1150.

Patched bug 1434219.

Filed bug 1434293.

Reviewed WPT PR 9259.

Commented on bug 1434313.

Continued work on marionette-window-tracking.

Patched bug 1434293.

Commented again on bug 1434313.

Filed bug 1434382.

Wednesday 31st

Commented on geckodriver issue 1152.