2019

July

Monday 1st

Fixed deserialisation of error types in the Marionette Rust library prototype, improved test framework so we don’t do string comparison which vastly improves compile time by dropping regex and lazy_static.

Prepared the remote protocol meeting for tomorrow.

Investigated Puppeteer examples and commented on bug 1562638.

Tuesday 2nd

More meeting prep.

Reviewed bug 1560301.

Reviewed WPT PR 17563.

Commented on WebDriver issue 1429.

Commented on bug 1562740.

Commented on bug 1540655.

Discussion about internal inter-domain IPC with ochameau and jdescottes.

Rebased bug 1540655 and tried to figure out how to get Node.js on the image.

Closed bug 1548289.

Provided needinfo on bug 1562043.

Commented on bug 1544393.

Filed bug 1562920.

Reviewed bug 1562935.

Did some work on a patch for bug 1553756, to let Runtime.evaluate run in the current frame's execution context by default.

Wednesday 3rd

Reviewed bug 1493907.

Consulted on Nupur’s Rust library project for Marionette.

Work on bug 1540655. Found that Python was confusing TaskCluster and Puppeteer when it tried calling subprocess.Popen.communicate(). This is worth bearing in mind in the future.

Continued work on bug 1553756 to make it possible to evaluate arbitrary scripts without providing an execution context ID.

1:1 with dburns.

Reviewed bug 1493907.

Filed git-cinnabar issue 218.

1:1 with Nupur.

Submitted a naïve patch for bug 1553756 to request some feedback, especially on testing.

Thurday 4th

Reviewed bug 1563040.

Attended remote protocol project handover meeting with dburns and sole.

Rebased and submitted new try runs with increasingly more debug output for bug 1540655. I am more and more led to suspect this is an issue of stdio redirection/piping. For some reason we are getting the *** You are running in headless mode. message, which in fact is the only message in Firefox that gets printed to stderr, but nothing from stdout.

Some minor work on refining the extraction of parameter deserialisation for the Marionette Rust library project.

Did some meeting preparation for next week’s remote protocol meeting.

Filed bug 1563526 to impement Page.reload’s scriptToEvaluateOnLoad parameter.

Field bug 1563533 for introducing a shared document inlining function for the remote agent’s browser chrome tests.

Did some work on bug 1549708 in implementing Page.reload’s ignoreCache parameter. The hardest part, it turns out, is writing the tests correctly for this feature.

Email conversation about Outreachy. Brainstorming for projects, &c.

Rebased bug 1543115. Still requires some more local changes to complete.

Followed up with a try run for bug 1553756.

Commented on bug 1543115 explaining that the bug’s priority just increased because even the workaround patch changing Puppeteer from listening on stderr to stdout doesn’t work when you are dealing with shippable builds. browser.dom.window.dump.enabled is implied for debug builds, which is why my work on bug 1543115 took so long to figure out!

Reviewed bug 1563621.

Friday 5th

Filed dino-park issue 134 about making tags searchable.

Filed bug 1563714 about a build problem after upgrading to rustc 1.36.0.

Filed bug 1563746 for implementing Page.captureScreenshot.

Followed up on code review feedback for bug 1553756.

Helped answer some questions about serde for Nupur. Experimented with a solution for automatically deserialising both the command name and the parameters.

Sunday 7th

Spent some time thinking about the data structure of the Marionette Rust library.

Monday 8th

Prototyped the params-associated-with-command alternative to the Marionette Rust library.

1:1 with Nupur.

Commented on geckodriver issue 1581.

Commented on and closed bug 1563714. Turns out CARGO_BUILD_PIPELINING=true is incompatible with rustc 1.36.0.

Reviewed bug 1562043 which fixes the trace logging of packets in geckodriver following the move to use the warp request handler.

Followed up on code review issues with bug 1540655. Based on review feedback from ahal, I discovered the new test flavour likely caused all the other test harnesses to break… The good news is that the Puppeteer tests are running successfully, but we’re likely missing to populate some data that it looks for. More investigation is needed.

Reviewed bug 1563685.

Tuesday 9th

Reviewed bug 1560836, which lands the serialisation framework for the new Marionette Rust library by Nupur.

Filed bug 1564416 and bug 1564417 as a follow-up bugs for Nupur.

Commented on WPT PR 17679 about Chrome apparently appending an additional slash to directories when served over the file:// protocol.

Wednesday 10th

Reviewed WPT PR 17679, after clarifying with Ms2ger that file:// is not standardised.

Reviewed bug 1544458.

Reviewed bug 1563687.

Thursday 11th

Reviewed WPT PR 17772.

Reviewed WPT PR 17769.

Closed geckodriver issue 1583.

Reviewed bug 1562740, which tries to test the raciness we experienced with DOM propagation of keyboard input events.

Filed bug 1565183 about the message manager disappearing in favour of JSWindowActor.

Commented on D37368.

Reviewed bug 1564416, which hooks the new Marionette Rust library up to geckodriver. This is major progress!

Filed bug 1565210.

Reviewed bug 1563692, which offers a significant refactoring to the remote agent with regarads to how requests and responses are handled.

Commented on bug 1565166.

Commented on bug 1565164.

Commented on bug 1564360.

Commented on bug 1564832.

Wrote a proposal for a Summer internship project for 2020.

Commented on WPT PR 17769.

Reviewed bug 1565359.

Friday 12th

Continued working on the Summer internship proposal.

Commented on WPT PR 17795.

Attended Outreachy chit-chat meeting.

Reviewed WPT 17805.

Monday 15th

1:1 with Nupur.

Reviewed WPT PR 17824.

Reviewed WPT PR 17813.

Solved some computer setup related problems. Sigh.

Reviewed bug 1563689.

Reviewed bug 1566008.

Filed bug 1566107 and commented on bug 1462896.

Finished drafting the Summer intern proposal.

Wednesday 17th

Commented on geckodriver issue 1586.

Commented on geckodriver issue 1585 and lated filed bug 1566778.

Commented on geckodriver issue 1584.

Provided needinfo on bug 1562043.

1:1 with dburns.

Commented on geckodriver issue 1587.

Thursday 18th

Reviewed bug 1562740.

Reviewed bug 1564417.

Reviewed bug 1563689.

Monday 22nd

Closed geckodriver issue 1591.

Closed geckodriver issue 1589.

Closed geckodriver issue 1590.

Closed geckodriver issue 1587.

Made request for updating the icecc-scheduler.corp.lon2.mozilla.com CNAME.

Rebased bug 1540655.

Tuesday 23rd

1:1 with whimboo to discuss Marionette and Fission.

Commented on geckodriver issue 1592.

Attended team chit-chat.

Attended remote protocol meeting.

Wednesday 24th

Provided needinfo on bug 1565183.

Reviewed D39110.

Patched bug 1566778 to make mozrunner/geckodriver search the system path for the firefox binary on different Unices.

Commented on geckodriver issue 1592.

Commented on bug 1564411.

Patched bug 1568540 to upgrade the url crate dependency in webdriver.

Continued work on bug 1540655.

Thursday 25th

Provided needinfo on bug 1565183.

Reviewed bug 1565210.

Commented on Selenium issue 395.

Commented on bug 1568540.

Continued work on bug 1540655.

Filed bug 1568873.

Filed and patched bug 1568865 to add missing license headers to the remote agent.

Commented on bug 1563746.

Filed and patched bug 1568881 to run rustfmt in CI on the Rust mozbase port.

Filed and patched bug 1568889 to run rustfmt in CI on geckodriver and the webdriver crate.

Commented on D39110.

Friday 26th

Provided needinfo on bug 1568991.

Reviewed bug 1568657.

Commented on D39368.

Filed and patched bug 1569140.

Rebased bug 1568881.

Reviewed several individual patches all associated with bug 1569100.

Commented on geckodriver issue 1594.

Attended Outreachy chit-chat.

Reviewed bug 1568991.

Monday 29th

Provided needinfo on bug 1569100.

Reviewed bug 1569466 which implements Deserialize for ErrorStatus in the webdriver Rust library.

Addressed review comments and uploaded new patches for bug 1540655.

Reviewed bug 1569100.

Submitted patches for bug 1563533, introducing a document in-lining helper function for the remote agent browser-chrome tests.

Rebased and addressed code review comments with bug 1553756, for allowing Runtime.evaluate to be used without an explicit execution context ID.

Tuesday 30th

Commented on D37008 about whether the new Puppeteer test job should be Tier-2 or Tier-3.

Continued review of bug 1569100.

Closed geckodriver issue 1596.

Wednesday 31st

Reviewed bug 1488475.

Filed bug 1570261 about ./mach bootstrap being broken this morning.

Continued reviewing bug 1569100.

Addressed review issues with bug 1563533.

Filed and patched bug 1570290 to fix a lint warning with the remote agent’s documentation.

Filed and patched bug 1570292 to resolve some visual inconsistencies with the visual cue we add when the browser session is remotely controlled.

Even more reviews on bug 1569100.

Filed and patched bug 1570302 which refactors the inline() helper in WPT, as well as fixes a couple of bugs.

Filed and patched bug 1570327 as a follow-up on bug 1570292 to also hide the robot icon when the address bar is in edit mode.

Commented on D39784.

Tried to help nupur figure out a serde problem.

Started work on bug 1570378 to make remote agent test setup more succinct.